Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial attempt at v1.12 for CTP #114

Merged
merged 3 commits into from
Jun 13, 2017
Merged

Initial attempt at v1.12 for CTP #114

merged 3 commits into from
Jun 13, 2017

Conversation

ProgrammerDan
Copy link
Contributor

Signed-off-by: ProgrammerDan programmerdan@gmail.com

Note this is still pre-6, I'll update this PR once Spigot releases non-dev.

Tested slightly on pre-6, works. You can leverage this immediately using ViaVersion 1.1.1.

@ProgrammerDan
Initial attempt at v1.12 for CTP
9c35d34 
Signed-off-by: ProgrammerDan <programmerdan@gmail.com>
@ProgrammerDan
Update to full 1.12 from pre6
2263dc3
@ProgrammerDan
Copy link
Contributor Author

Should be g2g. I'll be doing testing on this branch as I get the rest of my plugins up to date and update this PR if any issues arise. If you choose to merge it before I report back, I'll open new PRs with any fixes as they emerge.

@ProgrammerDan ProgrammerDan mentioned this pull request Jun 12, 2017
Open
@ProgrammerDan
Copy link
Contributor Author

Note I am seeing some config-API related changes that might cause some breaking, I'm digging into it.

@ProgrammerDan
Copy link
Contributor Author

That push fixed it, should be good now.

@Techcable
Copy link
Contributor

Techcable commented Jun 13, 2017 •
edited
Loading

Just a sec, I have to secretly upload craftbukkit 1.12-R0.1-SNAPSHOT to my repo or jenkins won't work.
Thanks for doing this update since I forgot 😉

@Techcable Techcable merged commit 9b6575f into Byteflux:master Jun 13, 2017
@ProgrammerDan ProgrammerDan deleted the mc1.12-mainline branch June 13, 2017 03:51
@ProgrammerDan
Copy link
Contributor Author

Happy to help out :D

@ProgrammerDan ProgrammerDan mentioned this pull request Jun 13, 2017
Closed
@ProgrammerDan
Copy link
Contributor Author

ProgrammerDan commented Jun 13, 2017 •
edited
Loading

Note that I have reports of no bar, so I'll probably need to check on & update the bar api for folks that use it

Nevermind, I had it turned off, d'oh!

@ProgrammerDan
Copy link
Contributor Author

@Techcable No new public build yet, much sadness for many? https://ci.minelink.net/ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ProgrammerDan @Techcable