Add purge=true to DeleteSnapshot and test for it

BytemarkHosting · Jan 13, 2017 · a7f30e1 · a7f30e1
1 parent 9085da4
commit a7f30e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/snapshot_calls.go b/lib/snapshot_calls.go
@@ -26,7 +26,7 @@ func (c *bytemarkClient) DeleteSnapshot(vm VirtualMachineName, discLabelOrID str
 	if err != nil {
 		return
 	}
-	r, err := c.BuildRequest("DELETE", BrainEndpoint, "/accounts/%s/groups/%s/virtual_machines/%s/discs/%s/snapshots/%s", vm.Account, vm.Group, vm.VirtualMachine, discLabelOrID, snapshotLabelOrID)
+	r, err := c.BuildRequest("DELETE", BrainEndpoint, "/accounts/%s/groups/%s/virtual_machines/%s/discs/%s/snapshots/%s?purge=true", vm.Account, vm.Group, vm.VirtualMachine, discLabelOrID, snapshotLabelOrID)
 	if err != nil {
 		return
 	}

diff --git a/lib/snapshot_calls_test.go b/lib/snapshot_calls_test.go
@@ -92,6 +92,9 @@ func TestDeleteSnapshot(t *testing.T) {
 			if req.Method != "DELETE" {
 				t.Fatalf("Wrong method %s", req.Method)
 			}
+			if req.URL.Query().Get("purge") != "true" { // TODO(telyn): should really be parsing this with url.Values and checking that "purge" == "true"
+				t.Errorf("Didn't incude the purge parameter")
+			}
 		}),
 	})
 	defer servers.Close()