-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change A Lot Of Emojis #131
Conversation
@C1710, are you procrastinating? |
I looked at them yesterday and I agree with most changes. I'm not at home right now, so I can't give you more details at the moment. |
If you'd like to, you, or I, can change the color back to white, but honestly, I don't know if that's a good idea. |
If it's alright with you I would wait a bit before merging to give others a chance to add some opinions (if anyone has any). |
The disguised face is based on SpongeBob posing as Squidward, plus glasses; although when I come to think about it, I can't remember exactly, which scene it was based on. To be honest, it's not a very good design and it would make sense to adapt the Noto one instead 😅 |
Are you talking about the drop color or the whole changes that I've made in general? |
No, I'm talking about everything, as it's all one PR. I mean, I could try to add the other changes first (not sure right now how that would work), but i don't think I will build a new font with it directly. |
Then how will you do it? Also, did you post the same comment twice? |
I mean, I'll rebuild the font only with the next release or so.
The mobile internet connection in this train is pretty bad, so probably yes 😂 |
So you are saying that in releases after that, you won't use the ones that I designed? |
I just wanted to say that I won't use them before that release 😅 |
Are you talking about the 15.1 release? |
Yes, so my plan is: Additionally I'm thinking about reverting the file names to all be |
Okay. Hope this goes well! |
Most changes look good to me, however:
Other changes are fine. |
@C1710 also, if you do merge these, please correct the palette as most of them look copied straight from Noto |
Don't worry, I'll look at it tomorrow 😅 |
If they will be broken forever, here's the ZIP file: |
How do you stop yourself from merging the files? |
That's actually the one nice thing about Git: Nothing is lost. We can revert that broken merge and then fix it. But not today anymore :D |
Also, when I installed the fork, the SVGs looked normal. |
Can you only revert that commit or will it affect the other commits? |
@C1710, I saw the SVGs on GitHub and they don't look broken, but the commit still thinks it's broken. Does that still mean that the files are broken? |
I made some changes. Do you think they're better? |
@C1710, I know that you are probably busy, but please respond. |
I fixed it now and applied some of the newer changes, but I think at this point you shouldn't add more stuff. This PR is already pretty large and hard to handle. |
If it's too large, I'll send you a ZIP file with ALL the changes. |
I meant there are already many changes at this point, you shouldn't add even more. It just makes it messier. |
I'm not gonna add anymore. |
I have the fixes on https://github.com/C1710/blobmoji/tree/emoji15.1-sayhone (plus I reverted the updates that I do not want to add). I don't know what's the best way to do the PR (maybe I open one and reference this one? You're still listed as the author/person that made the commits) and I don't have enough time for that at the moment. |
Why is there a bitmap in |
I'm not sure. Could be a mistake from an export. Affinity Designer (the software I use) often makes bitmaps out of features that it can't export to SVG. I usually don't use those but it might be possible, that there was a mistake there. I can fix that later (or tomorrow or so) though. |
I made a new PR based on the branch with the fixes and color corrections: #133. |
I like these color changes. |
Emoji updates (fixed/color-corrected version of #131)
I know this is a lot, but I feel that I should update some of them. Apologies if it adds files instead of updating them. By the way, what is the disguised face based on?