fix(parsing): Pass errors through callbacks

Don't make assumptions that users want the file stream destroyed when an error is encountered
C2FO · Jun 23, 2020 · 84ecdf6 · 84ecdf6
1 parent a4a1e3f
commit 84ecdf6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/parse/src/CsvParserStream.ts b/packages/parse/src/CsvParserStream.ts
@@ -82,7 +82,7 @@ export class CsvParserStream<I extends Row, O extends Row> extends Transform {
             const rows = this.parse(newLine, true);
             return this.processRows(rows, done);
         } catch (e) {
-            return this.destroy(e);
+            return done(e);
         }
     }
 
@@ -114,7 +114,7 @@ export class CsvParserStream<I extends Row, O extends Row> extends Transform {
         const iterate = (i: number): void => {
             const callNext = (err?: Error): void => {
                 if (err) {
-                    return this.destroy(err);
+                    return cb(err);
                 }
                 if (i % 100 === 0) {
                     // incase the transform are sync insert a next tick to prevent stack overflow