Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon4py merge greenline in main #825

Closed
wants to merge 29 commits into from

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Sep 10, 2023

Adapting icon and py-icon4py packages to icon4py PR https://github.com/C2SM/icon4py/pull/260

Includes

  • update build path in icon and icon4py
  • added dependencies in py-icon4py
  • new py-ghex package for python bindings of GHEX https://github.com/ghex-org/GHEX
    • packages for dependencies not yet available in spack 0.18
  • new patch version for serialbox to make the python extension run with numpy@1.24

@dominichofer
Copy link
Contributor

Please add spack info <package> and spack spec <package> tests for the new packages in test/integration_test.py. And spack install <package> tests in test/system_test.py. Once added, please trigger them in our CI system with a GitHub comment launch jenkins <package1> <package2> [docu]. Thank you!

@halungge
Copy link
Contributor Author

launch jenkins py-ghex py-hatch-vcs py-pyproject-metadata py-pytest-mpi py-pytest-subprocess py-setuptools-scm py-exceptiongroup py-flit-scm py-cattrs serialbox

@halungge
Copy link
Contributor Author

halungge commented Sep 10, 2023

Really? At least the spack info and spack spec tests you could easily generate. Just make it a parametrized test with generator function for all packages in the repo...

@halungge
Copy link
Contributor Author

launch jenkins py-cattrs

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-cattrs-spack_info
🟢py-cattrs-spack_spec
🟢 system test
Test
🟢PyCattrs-install_default

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-cattrs-spack_info
🟢py-cattrs-spack_spec
🟢 system test
Test
🟢PyCattrs-install_default

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-cattrs-spack_info
🟢py-cattrs-spack_spec
🟢 system test
Test
🟢PyCattrs-install_default

@halungge
Copy link
Contributor Author

launch jenkins py-ghex py-hatch-vcs py-pyproject-metadata py-pytest-mpi py-pytest-subprocess py-setuptools-scm py-exceptiongroup py-flit-scm py-cattrs serialbox

@jonasjucker
Copy link
Contributor

launch jenkins icon daint

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary

WARNING: Serial tests did not run for system tests

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary

WARNING: Serial tests did not run for system tests

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary

WARNING: Serial tests did not run for system tests

@jonasjucker
Copy link
Contributor

launch jenkins icon

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_serialization=create_claw=std-spack_spec

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🔴 system test
Test
🔴Icon-install_2_6_6_gcc
🔴Icon-install_2_6_6_nvhpc
🔴Icon-install_nwp_gpu

WARNING: Serial tests did not run for system tests

@abishekg7
Copy link
Contributor

@jonasjucker I'm also trying to build this locally on daint. There might be more fixes to come.

@abishekg7
Copy link
Contributor

@jonasjucker there are some updates to the builtin py-isort in spack:develop that seem to fix our issues. But should I extend the inbuilt py-isort and add the fixes, or just override it with the latest py-isort recipe?

@jonasjucker
Copy link
Contributor

@jonasjucker there are some updates to the builtin py-isort in spack:develop that seem to fix our issues. But should I extend the inbuilt py-isort and add the fixes, or just override it with the latest py-isort recipe?

I have no preference, if it is only a small fix, i.e. something like patch(xxx) or version(xxx) Id' prefer an extension.
Otherwise an override is good too. But better add an issue to not forget about the override.

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🔴 system test
Test
🟢Icon-install_2_6_6_gcc
🟢daint_cpu_cce
🟢daint_cpu_gcc
🟢daint_cpu_nvhpc
🟢daint_gpu_nvhpc
🔴daint_dsl_nvhpc

WARNING: Serial tests did not run for system tests

@abishekg7
Copy link
Contributor

launch jenkins icon daint

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢 system test
Test
🟢Icon-install_2_6_6_gcc
🟢daint_cpu_cce
🟢daint_cpu_gcc
🟢daint_cpu_nvhpc
🟢daint_cpu_nvhpc_out_of_source
🟢daint_gpu_nvhpc
🟢daint_dsl_nvhpc

@abishekg7 abishekg7 marked this pull request as draft September 19, 2023 12:13
@jonasjucker
Copy link
Contributor

moved to #834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants