Updates for release of BouncyCastle 1.56 #8
Conversation
peterdettman
commented
Dec 23, 2016
peterdettman
commented
- add maven entry for BC 1.56 and update the versions range
- DHIES weak crypto tests now pass if algs not even supported
- some ECIES entries moved to the invalid list
- ECIES decryption init calls fixed to pass the correct parameters
- EciesTest.testModifyPoint now expects GeneralSecurityException
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
- add maven entry for BC 1.56 and update the versions range - DHIES weak crypto tests now pass if algs not even supported - some ECIES entries moved to the invalid list - ECIES decryption init calls fixed to pass the correct parameters - EciesTest.testModifyPoint now expects GeneralSecurityException
peterdettman
force-pushed
the
bc_1_56
branch
from
010bff6
to
3e1e905
Compare
|
CLAs look good, thanks! |
|
Cool, thanks for working on this! I'll merge this PR after setting up two-way sync between GitHub and our internal repository, stay tuned. |
| @@ -296,7 +299,7 @@ public void testIsAlias(String algorithmA, String algorithmB) throws Exception { | |||
| byte[] message = "Hello".getBytes("UTF-8"); | |||
| eciesA.init(Cipher.ENCRYPT_MODE, keyPair.getPublic()); | |||
| byte[] ciphertext = eciesA.doFinal(message); | |||
| eciesB.init(Cipher.DECRYPT_MODE, keyPair.getPrivate()); | |||
| eciesB.init(Cipher.DECRYPT_MODE, keyPair.getPrivate(), eciesA.getParameters()); | |||
There was a problem hiding this comment.
Should this be eciesB.getParameters()?
There was a problem hiding this comment.
@thaidn Sorry for the delayed reply. Actually eciesA.getParameters() was correct, since we are trying to decrypt with the parameters that were used (possibly auto-generated) during encryption. Looking at current code it appears this was actually changed to eciesB, which ought to be reverted (there's currently a test failure with latest BC caused by using eciesB here).
