Add getters for all fields, even if undocumented #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the fields on some of the packets are missing their `:getter` documentation. However, that leaves client code unable to access those fields on the packets! This changes the generation script to output getters for all fields, even those which are undocumented.
|
The original intention was that not having getter docs defined meant that library consumers should not be able to get that field, but this meaning is mostly lost. In any case, it would make more sense to add an explicit not-accessible declaration or something for the fields that for whatever reason we don't want readable. On a side-note, it would be nice to drop the Clojure generation and rewrite it all with macros 1.1. Cherry-picked in as a5fe8b8 |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the fields on some of the packets are missing their
:getterdocumentation. However, that leaves client code unable to access those
fields on the packets! This changes the generation script to output
getters for all fields, even those which are undocumented.