Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

PATCH Http method support #326

Closed
wants to merge 2 commits into from
Closed

PATCH Http method support #326

wants to merge 2 commits into from

Conversation

lucasmodesto
Copy link

Hello,

We're implementing MAS SDK, but notice that HTTP method PATCH was missing.
After research I found that HttpUrlConnection don't support native PATCH method only on API < 19.

If server supports, even in lower API's we can send POST method with additional header "X-HTTP-Method-Override"
Our min SDK version is 22 at the moment, so we could use PATCH regardless of CA gateway HTTP-Method-Override support.

This fix was based on following issue: OneDrive/onedrive-sdk-android#16

Thanks

@Ruqiya-Kaladgi
Copy link
Contributor

Thanks Lucas, we will not be able to merge the changes now, but will make these changes in the SDK soon.

@Ruqiya-Kaladgi
Copy link
Contributor

Changes have been applied.

@lucasmodesto
Copy link
Author

Changes have been applied.

Thanks for replying Ruqiya!
I tried version 2.0.00 but still patch isn't available.
It'll be available on next release?

@Ruqiya-Kaladgi
Copy link
Contributor

Ruqiya-Kaladgi commented Oct 28, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants