Use multiprocessing.Pool.map() for parallelism
#182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 87.10% 88.37% +1.26%
==========================================
Files 25 25
Lines 1613 1591 -22
==========================================
+ Hits 1405 1406 +1
+ Misses 208 185 -23
|
We currently do not exit with non-zero if an uncaught exception occurs within a multiprocessing child process. `multiprocessing.Pool.map()` will kill all processes if any one process throws an exception and then re-raise that exception in the parent process. Fixes #122
SeanBryan51
force-pushed
the
122-handling-of-non-zero-exit-code-from-process-multiprocessing
branch
from
66043f8
to
068e0bb
Compare
Integration testsTest
|
ccarouge
reviewed
Oct 16, 2023
|
@ccarouge the behaviour should still be the same but I've run a case that fails the comparison: #!/bin/bash
bench_example_dir='bench_example_test_failed_bitwise_comparison'
rm -rf $bench_example_dir
git clone git@github.com:CABLE-LSM/bench_example.git $bench_example_dir
cd $bench_example_dir
git reset --hard 6287539e96fc8ef36dc578201fbf9847314147fb
cat > config.yaml << EOL
project: tm70
experiment: AU-Tum
realisations:
- path: trunk
- path: trunk
name: trunk-patch
patch:
cable:
cable_user:
SSNOW_POTEV: P-M
modules: [
intel-compiler/2021.1.1,
netcdf/4.7.4,
openmpi/4.1.0
]
EOL
benchcab run -vOutput from PBS job: |
ccarouge
approved these changes
Oct 16, 2023
SeanBryan51
deleted the
122-handling-of-non-zero-exit-code-from-process-multiprocessing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do not exit with non-zero if an uncaught exception occurs within a multiprocessing child process.
multiprocessing.Pool.map()will kill all processes if any one process throws an exception and then re-raise that exception in the parent process.Fixes #122