Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init fix #1

Merged
merged 6 commits into from
Sep 19, 2018
Merged

Init fix #1

merged 6 commits into from
Sep 19, 2018

Conversation

Jake-Shadle
Copy link
Contributor

Non-Windows platforms would fail to compile with ansi_term v0.11.0 since ansi_term::enable_ansi_support() is under a #[cfg(windows)] attribute, and the if cfg!(windows) check only applies at runtime thus the code inside the if is still compiled.

@Jake-Shadle
Copy link
Contributor Author

Oh, it also adds a Travis build to ensure *nix at least compiles. 🙂

@CAD97
Copy link
Owner

CAD97 commented Sep 19, 2018

Sorry, I thought I had tested on *nix!

I'll get proper great CI set up this weekend and make a patch release.

@CAD97 CAD97 merged commit a41755b into CAD97:master Sep 19, 2018
@Jake-Shadle
Copy link
Contributor Author

No problem, thanks for the quick turnaround!

@CAD97
Copy link
Owner

CAD97 commented Sep 24, 2018

I just published 0.2.1 with this fix.

@Jake-Shadle
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants