Initialize MVP model scope #4
Conversation
BenSchZA
changed the title
| EFFECTIVE_BALANCE_INCREMENT = [1 * constants.gwei], | ||
| PROPOSER_REWARD_QUOTIENT = [8], | ||
| WHISTLEBLOWER_REWARD_QUOTIENT = [512], | ||
| MIN_SLASHING_PENALTY_QUOTIENT = [32], |
There was a problem hiding this comment.
Not sure if it was intended, but on the eth2 specs, the MIN_SLASHING_PENALTY_QUOTIENT is set to 128.
There was a problem hiding this comment.
@marthendalnunes great work picking that up! So this is something we could introduce phases for, or consider the steady state which would be 32. I believe the "blueprint" economic report model chose to not introduce phases, mainly because they couldn't introduce too many degrees of freedom in a spreadsheet model. In our case we could.
|
|
||
| return { | ||
| 'total_basefee': total_basefee, | ||
| 'total_tips_to_validators': total_tips_to_validators, |
There was a problem hiding this comment.
Does this nomenclature total_tips_to_validators considers a post eth1/eth2 merge?
There was a problem hiding this comment.
See comment in Slack. EIP1559 would be introduced in phase 2, so I believe you're correct. The economic report considers the steady state, we can possibly introduce phases if necessary specifically for EIP1559.
| validating_penalties = previous_state['validating_penalties'] | ||
| total_tips_to_validators = previous_state['total_tips_to_validators'] | ||
|
|
||
| total_online_validator_rewards = validating_rewards + whistleblower_rewards - validating_penalties + total_tips_to_validators |
There was a problem hiding this comment.
Is this considering the model is for phase 2?
add plotly to requirements.txt
ignore node aux files and directories
…terclass into init-states-params
|
See python/typeshed#3500 for issue re. typing: import sys
if sys.version_info >= (3, 8):
from typing import TypedDict, Literal, overload # pylint: disable=no-name-in-module
else:
from typing_extensions import TypedDict, Literal, overload |
There are a number points to review, indicated by
NOTEs andTODOs in the code.To review:
Some of these could be reviewed and refactored in subsequent tickets, in the interest of getting the MVP implementation completed for further iteration and development.