Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/refactor accounting voucher row #1516

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Feature/refactor accounting voucher row #1516

merged 8 commits into from
Jul 15, 2024

Conversation

Julian0701
Copy link
Member

DEVELOP

  • Refactor AccountingVoucherRow
  • Restrict register user name

Related Issues

Checklist

  • Used @ in import paths.
  • Verified naming convention compliance (Naming Convention Guidelines).
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 1
    • src/components/accounting_voucher_row/accounting_voucher_row_mobile.tsx
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML Diagrams

  • None

Additional Notes

  • Ensured all links are up-to-date.
  • Conducted thorough testing on responsive design changes.
  • Documented any notable considerations or edge cases addressed.

@Julian0701 Julian0701 self-assigned this Jul 12, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-sun-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 5:33am

@Julian0701 Julian0701 linked an issue Jul 12, 2024 that may be closed by this pull request
[Bug] 日記帳頁面－跳轉到日記帳頁面填入文字會整個頁面無法跳轉 #1372
Closed
Luphia
Luphia approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 15b0f9a into develop Jul 15, 2024
4 checks passed
@Luphia Luphia deleted the feature/refactor_accounting_voucher_row branch July 15, 2024 08:11
@Luphia Luphia added this to the v0.8.0 Alpha Release milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@arealclimber arealclimber Awaiting requested review from arealclimber

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
v0.8.0 Alpha Release
Development

Successfully merging this pull request may close these issues.

[Bug] 日記帳頁面－跳轉到日記帳頁面填入文字會整個頁面無法跳轉
2 participants
@Julian0701 @Luphia