Fix ipv4 to asn recipe to use donwloaded pfx2as file #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amacaida
reviewed
Feb 8, 2024
|
|
||
| Sample ips.txt found [here]( http://data.caida.org/datasets/topology/ark/ipv4/dns-names/2019/05/dns-names.l7.20190501.txt.gz) | ||
| Download a prefix2asn file by following the directions [here](https://catalog.caida.org/dataset/routeviews_prefix2as). When using the script, pass in the file name after the `-p` flag. |
There was a problem hiding this comment.
In general, avoid using a link named "here". Prefer "...following the directions detailed on the [Dataset Icon
RouteViews Prefix to AS mappings] entry"
amacaida
reviewed
Feb 8, 2024
|
|
||
| **Usage** : `$ python3 ip_asn.py -i ips.txt` | ||
| Sample lists of IPs found [here]( http://publicdata.caida.org/datasets/topology/ark/ipv4/dns-names/2019/05/dns-names.l7.20190501.txt.gz). |
There was a problem hiding this comment.
"here" should be renamed to whatever this file is.
|
@richmass1 can you address the "here" links I commented on? |
Changing the text of links that previously said "here", as requested by a comment on #726. I also removed some links that had sparse information or were no longer active.
I did my best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #724