Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all POIs on the map #104

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Show all POIs on the map #104

merged 6 commits into from
Mar 21, 2024

Conversation

linyc0817
Copy link
Contributor

Description

Show all POIs directly on the map instead of only the POI for the current cluster

Changes

截圖 2024-03-11 下午3 33 15 截圖 2024-03-11 下午3 34 49

Notes

Remain unknown data in Poi drawer, will be solved on remove cluster PR

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings
  • Any changes to strings have been published to our translation tool
  • I conducted basic QA to assure all features are working
  • I requested code review from other team members

Resolved Issues

#84

hsinlun99 and others added 6 commits December 27, 2023 16:52
* refactor: 📝 add cluster list status icon images

* refactor: 💄 status style on cluster refactor

* refactor: 🚚 rename the function name of status icon
* feat(Cluster Drawer): ✨ Change the POI list order to random

* feat(Marker): 🐛 Set entry and facility markers to unclickable

* fix: 🔥 Remove unused map function
@hsinlun99
Copy link
Contributor

hsinlun99 commented Mar 21, 2024

well done!
A button for adding reports is needed. it can be done in the future PR.

@hsinlun99 hsinlun99 merged commit 1a185d6 into vanguard Mar 21, 2024
1 of 2 checks passed
peoplepeople000 pushed a commit that referenced this pull request Apr 2, 2024
* [Research] refactor the style of status on cluster drawer (#81)

* refactor: 📝 add cluster list status icon images

* refactor: 💄 status style on cluster refactor

* refactor: 🚚 rename the function name of status icon

* Linyc/random ordered list (#97)

* feat(Cluster Drawer): ✨ Change the POI list order to random

* feat(Marker): 🐛 Set entry and facility markers to unclickable

* fix: 🔥 Remove unused map function

* docs: 📝 update cluster center for research requirement (#98)

* feat(POI): ✨ Show the Pois directly on map

* feat(Drawer): ✨ Change Poi marker click action to open drawer

* feat(Drawer): ✨ Change the Poi drawer dismiss back to homepage

---------

Co-authored-by: hsinlun <43398440+hsinlun99@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Research] POI: show all POIs on the map instead of only the POI for the current cluster
2 participants