SDO: fix broken block download #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix wrong double calling CO_SDO_receive_done for last segment in subblock/block. This is critical fix for PR CANopenNode#174 issue CANopenNode#39
|
It must be merged in old 1.3-master, but @CANopenNode it is up to you what to do with master, especially if you refactoring SDO. But take into account that current SDO block can't work at all for data longer than blksize. |
CANopenNode
added a commit
that referenced
this pull request
Jul 13, 2020
by lukegluke, same as commit in v1.3-master
|
I fixed the same also in master. |
|
Ok, thanks! |
henrikbrixandersen
pushed a commit
to vestas-wind-systems/CANopenNode
that referenced
this pull request
Oct 19, 2021
Fix wrong double calling CO_SDO_receive_done for last segment in subblock/block. This is critical fix for PR CANopenNode#174 issue CANopenNode#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong double calling CO_SDO_receive_done for last segment in subblock/block.
This is critical fix for PR #174
issue #39
Before this patch SDO block download was not working if there is no sequence breaks or timeouts (if SDO buffer not gets empty while receiving block). If data size is bigger or equal to blocksize, on receiving last segment, bug caused SDO to process wrong message buffer from FIFO while waiting block end sequence that leads to SDO abort 0504 0001h (client/server command specifier not valid or unknown).
It was caused by wrong double calling CO_SDO_receive_done on block end (one call in full buffer check and one in block end check) that broke FIFO receive pointer. Workaround was to set CO_SDO_BUFFER_SIZE greater than 127*7 (889 bytes) or work with CANopen master that always brake sequence on downloading :)
This fix preserve "old logic" we discuss in #205 issue.