Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2d image fitting #150

Closed
6 of 9 tasks
Kechil opened this issue Apr 4, 2019 · 2 comments · Fixed by #1237
Closed
6 of 9 tasks

2d image fitting #150

Kechil opened this issue Apr 4, 2019 · 2 comments · Fixed by #1237
Assignees
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend

Comments

@Kechil
Copy link

Kechil commented Apr 4, 2019

related frontend issue CARTAvis/carta-frontend#1397

This is to provide users the ability to select a region and fit a 2D function such as 2D Gaussian to get feature properties. Note that full resolution image data need to be used as fitting input, instead of downsampled data.

Requirement document:
https://docs.google.com/document/d/1E9kL7FOhVtkDDit8VIYle61tU5PzSYXjnLpxZBCHliY/edit?usp=sharing

Implementation plan:

  • Basic single/multiple gaussian fitting and text outputs
  • Gaussian fitting with fixed initial values
  • Gaussian fitting of the current view in frontend
    ---- target for v3b3 ----
  • Output model/residual images
  • Estimate progress and listen for cancellation messages
  • Gaussian fitting of selected regions
  • support a background level in the fitting
  • support different solvers in the fitting
  • also use beam deconvolved image as the input data for fitting moved to new issue Image fitting with beam deconvolved images #1236
@kswang1029
Copy link
Contributor

kswang1029 commented Apr 16, 2019

Requirements:

  • provide 2d gaussian function as a start.
  • capability to define initial guess of fitting parameters (via a dialog or draw a box with cursor)
  • capability to fix part of fitting parameters
  • provide fitting results in convenient units (e.g., gaussian center in pixel and wcs coordinates)
  • provide fitting errors
  • capability to fit multiple gaussians (could consider to have an upper limit, say 3 or 5) in a single shot
  • export fitting results as a text file

@Kechil
Copy link
Author

Kechil commented Nov 16, 2019

v1.5

@kswang1029 kswang1029 added the requiring frontend this backend issue requires work in both frontend and backend label Nov 19, 2020
@kswang1029 kswang1029 added the enhancement New feature or request label Jun 8, 2021
@kswang1029 kswang1029 added this to the v3.0b-3 milestone Jan 9, 2022
@veggiesaurus veggiesaurus modified the milestones: v3.0b-3, v3.0-stable Jun 8, 2022
@veggiesaurus veggiesaurus removed this from the v3.0-stable milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants