Yuhsuan/150 fov fitting #1128
Merged
Yuhsuan/150 fov fitting #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuHsuan-Hwang
requested review from
veggiesaurus,
confluence,
pford and
kswang1029
3 tasks
|
@YuHsuan-Hwang this draft PR works fine as far as I can tell. It works with matched image as well. @veggiesaurus @confluence @pford please proceed with code review. 🙂 |
|
Update: added unit tests. also fixed incorrect pixel number in |
pford
requested changes
Jun 21, 2022
pford
approved these changes
Jun 22, 2022
kswang1029
approved these changes
Jun 23, 2022
confluence
approved these changes
Jun 24, 2022
|
pending approval before all e2e test passing again |
kswang1029
approved these changes
Jun 28, 2022
veggiesaurus
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the third item in #150: image fitting with field of view.
Details:
With the fov info sent from the frontend, the backend creates a temporary region to obtain the region data. The image fitter applies an offset to the center positions of Gaussian components when fitting the region. The temporary region is removed after the fitting task is done.
The advantage of this approach is that we support fitting the current fov of a rotated image (usually a spatially matched image) without implementing complicated calculation. In addition, the users can reproduce the fitting result by saving a subimage of the fov region (with info provided in the frontend). The reproduce steps will be simpler after we support image fitting with created regions in the future (probably only few-lines change to support this).
Using the region data requires slightly more memory usage than using the existed image cache, but the patterns of the CPU and momery profiles are similar. Please check the link for details of the performance tests:
https://docs.google.com/document/d/1orLw1Szpy8awVvypkAdAwhkS1u9lYuxkiOah-9hROrE/edit?usp=sharing
Update: also fixed incorrect pixel number in
FuncF()when fitting images with nan pixelsCorresponding PRs:
CARTAvis/carta-frontend#1885
CARTAvis/carta-protobuf#74
Still working on:add unit testssend protobuf PR