Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend crashes on RedHat platforms when certain folders aren't accesible #945

Closed
veggiesaurus opened this issue Oct 20, 2021 · 1 comment · Fixed by #946
Closed

Backend crashes on RedHat platforms when certain folders aren't accesible #945

veggiesaurus opened this issue Oct 20, 2021 · 1 comment · Fixed by #946
Assignees
Labels
bug Something isn't working
Milestone

Comments

@veggiesaurus
Copy link
Collaborator

The backend throws a std::filesystem_error exception and crashes when some folders aren't accessible on certain linux distributions (currently only reproducible on RHEL7) .

For example, if /etc/carta or ~/.carta isn't accessible, the backend can crash with an error in the log:

[critical] filesystem error: status: Permission denied.

I suspect it has to do with not catching exceptions thrown from std::filesystem::exists calls.

@veggiesaurus veggiesaurus added the bug Something isn't working label Oct 20, 2021
@veggiesaurus veggiesaurus added this to the v3.0b-2 milestone Oct 20, 2021
@veggiesaurus veggiesaurus self-assigned this Oct 20, 2021
@veggiesaurus
Copy link
Collaborator Author

Actually, I can reproduce this on ubuntu as well.

For example, calling fs::exists("/root") as a normal user works fine (it returns true), but calling fs::exists("/root/somefile") results in an error getting thrown. This presents problems if the user can't access /etc/carta, or something has been messed up and the user is trying to access a different user's $HOME/.carta (:facepalm: :facepalm: :facepalm: this should never happen, but people don't always follow instructions with carta-controller)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant