-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional error handling when checking for file existence #946
Conversation
… situations where parent directories can't be read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few comments. A couple of minor comments, and another more general across the changes regarding the use of fs::exists
. Is the purpose of using fs::exists(p, ec)
just using the overload of fs::exists
that doesn't throw an exception?
…eption handling to preferences check
I agree that we should be consistent about either using the functions that throw or the functions that do not. |
I have changed them all, except for one: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments!. Looks great.
Closes #945 by adding additional error handling when calling
fs::exists