-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confluence/remove grpc #1022
Confluence/remove grpc #1022
Conversation
…pting flag from session manager instead of passing redundant parameter.
…ndpoints. Tweaked commandline options and help text; added deprecation warnings. Fixed some bugs.
… session is destroyed.
…stalled as a dependency of protobuf-compiler-grpc, which was removed.
…to clean up function parameter definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one very minor comment from me, otherwise looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!. I added one minor comment regarding deprecated variables. But more importantly, can I suggest changing the name of SimpleHttpServer
to HttpServer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!.
This PR removes the gRPC server and moves the scripting API to an endpoint in the HTTP server. The HTTP server has been renamed, and its different functions have been decoupled from one another so that they can be enabled and disabled independently. Commandline options have been adjusted.
This PR should be merged at the same time as the companion PRs in the wrapper, frontend, protocol buffers, controller and website.