Fix a bug of stokes animation when playing backward #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mark/fix_stokes_animation_playback
kswang1029
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
tested. Playback modes backward and bouncing are now functional with the polarization axis. thanks @TienHao for finding this issue and @markccchiang for fixing this. 👍
confluence
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is to solve the stuck problem of stokes animation when playing backward. This is one of the commits in the draft PR 948. But I think it is better to merge this code change in a separate PR.