Fix PV preview updates for matched image #1305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PV preview for a matched image does not update when the PV cut is moved. The original PV request uses the matched image file_id but the cut region updates (SetRegion) use the reference file_id.
Fixes PV preview does not update for matched image #1304
The cut region's reference file_id is saved in PvCutParameters in addition to the file_id for the PV request. When SetRegion is sent, this reference file id is checked to see if an update should be generated.
This issue is described in frontend #2240 but it is a backend fix only.
See frontend issue; start a PV preview for a matched image and move the PV cut. The preview should update.
Checklist
no changelog update neededprotobuf updated to the latest dev commit/ no protobuf update needed