Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PV preview updates for matched image #1305

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

pford
Copy link
Collaborator

@pford pford commented Aug 31, 2023

Description
The PV preview for a matched image does not update when the PV cut is moved. The original PV request uses the matched image file_id but the cut region updates (SetRegion) use the reference file_id.

  • What is implemented or fixed? Mention the linked issue(s), if any.
    Fixes PV preview does not update for matched image #1304
  • How does this PR solve the issue? Give a brief summary.
    The cut region's reference file_id is saved in PvCutParameters in addition to the file_id for the PV request. When SetRegion is sent, this reference file id is checked to see if an update should be generated.
  • Are there any companion PRs (frontend, protobuf)?
    This issue is described in frontend #2240 but it is a backend fix only.
  • Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
    See frontend issue; start a PV preview for a matched image and move the PV cut. The preview should update.

Checklist

  • changelog updated / no changelog update needed
  • e2e test passing / corresponding fix added / new e2e test created
  • protobuf updated to the latest dev commit / no protobuf update needed
  • added reviewers and assignee
  • added ZenHub estimate, milestone, and release

@pford pford added this to the v4.0-stable milestone Aug 31, 2023
@github-actions
Copy link

Code Coverage

Package Line Rate Health
src.Cache 66%
src.DataStream 52%
src.FileList 67%
src.Frame 50%
src.HttpServer 42%
src.ImageData 28%
src.ImageFitter 89%
src.ImageGenerators 43%
src.ImageStats 76%
src.Logger 44%
src.Main 54%
src.Region 18%
src.Session 29%
src.Table 52%
src.ThreadingManager 87%
src.Timer 85%
src.Util 48%
Summary 38% (7029 / 18596)

Copy link
Contributor

@kswang1029 kswang1029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually and it looks good. no regression from the current e2e test suite. Please proceed code review. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PV preview does not update for matched image
3 participants