-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjustments to sudo call and log test #98
Conversation
I think that there should be some kind of warning. This may be a good time to add a changelog, so that it can be included in the package metadata. We should probably also add the changelog to the documentation. Is there any way for an npm package to print messages for the user upon installation? |
I wonder if a safer option would be 1) to give the user explicit control over the If we did that, we could just add a note to the extended configuration explaining what to do with an older version of We could also automatically detect the |
That's a good point. I've actually just tried bionic and centos7/8 docker images, and they all seem to have a new enough |
@confluence I have now added the config option you suggested, please re-evaluate |
* backport #98 * version bump
Closes #97
@confluence do you think we need to warn users about the additional line in the sudoers file that is now needed?