New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thchang/issue 697 #1265
Thchang/issue 697 #1265
Conversation
src/stores/AppStore.ts
Outdated
const frameInfo: FrameInfo = { | ||
fileId: ack.fileId, | ||
directory, | ||
hdu, | ||
fileInfo: new CARTA.FileInfo(ack.fileInfo), | ||
fileInfoExtended: new CARTA.FileInfoExtended(ack.fileInfoExtended), | ||
fileFeatureFlags: ack.fileFeatureFlags, | ||
renderMode: CARTA.RenderMode.RASTER | ||
renderMode: CARTA.RenderMode.RASTER, | ||
beamTable: beamTable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just use ack.beamTable ?? []
here? Why do we need to manually clone the beam table?
@TienHao please fix merge conflicts, then we can merge this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go! 👍
closes #697
implmenting beamTable to display correct beam for multi-beam images(per-plane-beam images).
companion backend issue CARTAvis/carta-backend#402