Webitools 198 add target compatible console version check before running the tools lfo #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble_Console_version_check_before_running_the_Tools_LFO' into WEBITOOLS-198_Add_target_compatible_Console_version_check_before_running_the_Tools_LFO # Conflicts: # aip-console-jenkins/src/test/java/io/jenkins/plugins/aipconsole/OnboardApplicationDeepAnalysisBuilderTest.java
…rsion_check_before_running_the_Tools_LFO
CAST-ANJ
reviewed
Sep 6, 2023
| @@ -332,7 +339,7 @@ public AddVersionDescriptorImpl getDescriptor() { | |||
| } | |||
|
|
|||
| @Override | |||
| public void perform(@Nonnull Run<?, ?> run, @Nonnull FilePath workspace, @Nonnull Launcher launcher, @Nonnull TaskListener listener) throws InterruptedException, IOException { | |||
| protected void performClient(@Nonnull Run<?, ?> run, @Nonnull FilePath workspace, @Nonnull Launcher launcher, @Nonnull TaskListener listener) throws InterruptedException, IOException { | |||
There was a problem hiding this comment.
Is this class package private, since protected is being used?
| @@ -172,7 +173,7 @@ public AnalyzeDescriptorImpl getDescriptor() { | |||
| } | |||
|
|
|||
| @Override | |||
| public void perform(@Nonnull Run<?, ?> run, @Nonnull FilePath workspace, @Nonnull Launcher launcher, @Nonnull TaskListener listener) throws InterruptedException, IOException { | |||
| public void performClient(@Nonnull Run<?, ?> run, @Nonnull FilePath workspace, @Nonnull Launcher launcher, @Nonnull TaskListener listener) throws InterruptedException, IOException { | |||
There was a problem hiding this comment.
in AddVersionBuilder it is protected and here it is public. Why this change in access modifier for same type of code?
| @@ -83,20 +82,8 @@ public ArchitectureStudioBuilder(String applicationName) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void perform(@Nonnull Run<?, ?> run, @Nonnull FilePath filePath, @Nonnull Launcher launcher, @Nonnull TaskListener listener) throws | |||
| public void performClient(@Nonnull Run<?, ?> run, @Nonnull FilePath filePath, @Nonnull Launcher launcher, @Nonnull TaskListener listener) throws | |||
| @Override | ||
| public CreateAppDescriptorImpl getDescriptor() { | ||
| return (CreateAppDescriptorImpl) super.getDescriptor(); | ||
| } | ||
|
|
||
| @Override | ||
| public void perform(@Nonnull Run<?, ?> run, @Nonnull FilePath workspace, @Nonnull Launcher launcher, @Nonnull TaskListener listener) throws InterruptedException, IOException { | ||
| public void performClient(@Nonnull Run<?, ?> run, @Nonnull FilePath workspace, @Nonnull Launcher launcher, @Nonnull TaskListener listener) throws InterruptedException, IOException { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.