Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make array index base 0/1 selectable #208

Closed
fajansen opened this issue Aug 31, 2020 · 4 comments
Closed

Make array index base 0/1 selectable #208

fajansen opened this issue Aug 31, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@fajansen
Copy link

To make coupling with other FMUs that use 0 as a base for array indices easier, provide a switch to select base 0 or 1.
@t-sommer
Copy link
Contributor

t-sommer commented Sep 7, 2020

I'll leave this issue open until modelica/fmi-standard#1128 is resolved.

@t-sommer
Copy link
Contributor

@fajansen, since there seems to be consensus in the FMI group that 0-based indexing was always allowed, would it be ok to switch to 0-based for the FMU export?

@fajansen
Copy link
Author

fajansen commented Sep 10, 2020 •
edited
Loading

Yes, that would be perfect for me.

t-sommer added a commit that referenced this issue Sep 14, 2020
@t-sommer
Use 0-based indexing when exporting FMI 2.0 arrays
adfc6e6 
in grtfmi.tlc and rtwsfcnfmi.tlc

fixes #208
@t-sommer
Copy link
Contributor

@fajansen, can you give adfc6e6 a try?

@t-sommer t-sommer added the enhancement New feature or request label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t-sommer @fajansen