Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated issues link broken #1228

Closed
syamfarh opened this issue Nov 19, 2023 · 2 comments · Fixed by #1233
Closed

Duplicated issues link broken #1228

syamfarh opened this issue Nov 19, 2023 · 2 comments · Fixed by #1233
Labels
category.Bug p.High prefer to be fixed in the next few releases

Comments

@syamfarh
Copy link

Describe the bug
Clicking on duplicated issues from original issues cause uncaught promises

To Reproduce
Steps to reproduce the behavior:

  1. Create two issues.
  2. Go to the second issue, mark as duplicated issue to the first issue.
  3. Go back to the first issue. Under the section of duplicated issues, click the link to the second issues

Expected behavior
Redirect to second issue page

Actual behaviour
Uncaught promise error popped up

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Firefox
  • Version 119.0.1 (64-bit)
@damithc
Copy link
Contributor

damithc commented Nov 19, 2023

Thanks for reporting this @syamfarh @CATcher-org/active-devs will look into this.

@damithc
Copy link
Contributor

damithc commented Nov 19, 2023

@syamfarh I can reproduce this bug as well. Might not be able to fix in a hurry though (best not to risk regressions by fixing non-critical bugs while a PE is in progress). In the meantime, you can navigate to the bug in concern from the main list of bugs, as shown below:

image

@damithc damithc added the p.High prefer to be fixed in the next few releases label Nov 19, 2023
gycgabriel pushed a commit that referenced this issue Jan 25, 2024
Fix the broken link of a duplicate issue

Currently, the user cannot open the link to a duplicate issue
when opening an issue, as described in #1228.

The links now work as expected.
vigneshsankariyer1234567890 added a commit that referenced this issue Mar 4, 2024
* Fix broken duplicate link (#1233)

Fix the broken link of a duplicate issue

Currently, the user cannot open the link to a duplicate issue
when opening an issue, as described in #1228.

The links now work as expected.

* Add whitespace validation (#1237)

* Add whitespace validation

* Update whitespace validation for new issue

* Update whitespace validation for title of new issues

* Update whitespace validation for title of new issues

* Move validators into core

* Update import order

---------

Co-authored-by: Misra Aditya <e1096355@u.nus.edu>

* Fix uncaught errors when attempting to access an invalid route

There is an uncaught error when the users click on an invalid internal link in Markdown or enter an invalid link in browser.

Internal links are unlikely to be used for bug reporting and are more likely to be invalid.

Let's show an error toaster and stop the navigation when clicking on an internal link in Markdown. Also, redirect the users to the login page if the users enter invalid link in browser.

* Set default branch to `main`

Previously, image uploads depend on the user's default branch.
Now, we set the branch for image upload to be `main`. Images will 
be uploaded to `main` as a result.

---------

Co-authored-by: Chee Hong <c.h.wong2606@gmail.com>

* Preserve linebreaks (#1241)

With preserving linebreaks, subset list items are rendered as a list,
and paragraph rendering is the same as Github.

* Faulty list view when back navigating (#1243)

Issue table settings such as page index are not 
saved when table is re-mounted.

This behavior inconveniences users as their settings 
are reset everytime they navigate to a specific issue and back.

Let's lift up the table settings of each mounted table to 
a service which the tables pull from when mounted.

* Upgrade to Angular 12 (#1242)

Some of our packages are old and outdated. We should actively maintain 
and keep these packages up-to-date so it is easier to maintain in the 
future.

Let's upgrade to Angular 12 to keep our packages up-to-date.

* Fix markdown blockquote preview difference (#1245)

Due to DOMPurify, the content used for preview is different.
However, given that ngx-markdown already has sufficient sanitation
by default, we remove sanitation by DOMPurify.

* Create release for v3.5.3

---------

Co-authored-by: Nguyen <87511888+nknguyenhc@users.noreply.github.com>
Co-authored-by: AdityaMisra <114080910+MadLamprey@users.noreply.github.com>
Co-authored-by: Misra Aditya <e1096355@u.nus.edu>
Co-authored-by: NereusWB922 <107099783+NereusWB922@users.noreply.github.com>
Co-authored-by: Chee Hong <c.h.wong2606@gmail.com>
Co-authored-by: Arif Khalid <88131400+Arif-Khalid@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category.Bug p.High prefer to be fixed in the next few releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants