Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor generate Session ID function #536

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Refactor generate Session ID function #536

merged 1 commit into from
Jan 16, 2021

Conversation

dingyuchen
Copy link
Contributor

@dingyuchen dingyuchen commented Jan 16, 2021 •
edited by anubh-v

Fixes #520
Wrap code to generate session ID into its own function such that AuthService does not call uuid() directly.
generateSessionId() resides in shared/lib

@anubh-v anubh-v self-requested a review January 16, 2021 05:22
@anubh-v
Copy link
Contributor

anubh-v commented Jan 16, 2021 •
edited

Looks good, can you propose a commit message as well?
Let's have a more descriptive title for the PR. You can add 'fixes #520` in the PR description.

@dingyuchen dingyuchen changed the title Solves #520 Refactor generate Session ID function Jan 16, 2021
@anubh-v anubh-v merged commit 7284251 into CATcher-org:master Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubh-v anubh-v anubh-v approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session ID: Abstract out logic for generating session ID
2 participants
@dingyuchen @anubh-v