-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Staging Site Deployment from CATcher repository #546
Conversation
Do Note: I have changed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can remove the cicd/staging-deployment
references so we can merge.
Another request: do add a brief comment into each workflow YAML, just stating their purpose
(for future maintainers)
…org/CATcher into cicd/staging-deployment
Summary
This PR fixes #542
This PR is an followup to #534, which uses Github Actions to do deployment on CATcher-staging using Github Actions
Note: Please do not merge until the todos are completed!
Description
The files following play their roles in the development of the staging site at CATcher's Staging Site
Workflow Files
staging-fetch.yml
enables it such that we are able to fetchCATcher-org/CATcher
's master information on push into theCATcher-org/CATcher-staging
repository.staging-deployment.yml
Following which, once themaster
branch ofCATcher-org/CATcher-staging
is updated, it will activate the workflow in this file to send a build request onto github pages.Other Files
environment.staging.ts
provides the configuration for the staging site. Do note that theclientId
provided by @JunWei96 helps it such that the callback URL is athttps://catcher-org.github.io/CATcher-staging/
Todos
I will force push the
master
branch ofCATcher-staging
back to be the same asCATcher
so that their master branches will be even .I will remove
cicde/staging-development
from this line before merge