Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Staging Site Deployment from CATcher repository #546

Merged
merged 27 commits into from
Jan 27, 2021

Conversation

seanlowjk
Copy link
Contributor

@seanlowjk seanlowjk commented Jan 20, 2021

Summary

This PR fixes #542

This PR is an followup to #534, which uses Github Actions to do deployment on CATcher-staging using Github Actions

Note: Please do not merge until the todos are completed!

Description

The files following play their roles in the development of the staging site at CATcher's Staging Site

Workflow Files

staging-fetch.yml enables it such that we are able to fetch CATcher-org/CATcher 's master information on push into the CATcher-org/CATcher-staging repository.

staging-deployment.yml Following which, once the master branch of CATcher-org/CATcher-staging is updated, it will activate the workflow in this file to send a build request onto github pages.

Other Files

environment.staging.ts provides the configuration for the staging site. Do note that the clientId provided by @JunWei96 helps it such that the callback URL is at https://catcher-org.github.io/CATcher-staging/

Todos

  • I will force push the master branch of CATcher-staging back to be the same as CATcher so that their master branches will be even .

  • I will remove cicde/staging-development from this line before merge

@seanlowjk seanlowjk requested a review from a team January 20, 2021 08:19
@seanlowjk
Copy link
Contributor Author

Do Note: I have changed the origin on environment.prod.ts to 'https://catcher-org.github.io' in order for the authentication request to get through ><

Copy link
Contributor

@ptvrajsk ptvrajsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Good job

@ptvrajsk ptvrajsk requested a review from anubh-v January 23, 2021 14:12
Copy link
Contributor

@anubh-v anubh-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can remove the cicd/staging-deployment references so we can merge.

Another request: do add a brief comment into each workflow YAML, just stating their purpose
(for future maintainers)

@seanlowjk
Copy link
Contributor Author

@ptvrajsk @anubh-v I have made the modifications above! Do let me know if there are any further issues!

Proposed Commit Message:

Adds two new workflow files and a staging configuration
which help to enable automatic deployment of our 
staging web application. 

@anubh-v anubh-v merged commit a69de23 into master Jan 27, 2021
@seanlowjk seanlowjk deleted the cicd/staging-deployment branch October 10, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Up Staging Site for CATcher Upon New Commits
3 participants