Electron entry script: Move supporting logic into utility functions #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an unused class in the app.component.spec.ts file. Removing this unused class will make code neater and more readble. Let's remove the unused stub class from this file.
…github.com/kkangs0226/CATcher into electron-entry-script-move-menu-definition
…electron-entry-script-move-supporting-logic
…electron-entry-script-move-supporting-logic
seanlowjk
reviewed
Jan 21, 2021
ptvrajsk
requested changes
Jan 21, 2021
ptvrajsk
approved these changes
Jan 22, 2021
anubh-v
reviewed
Jan 22, 2021
anubh-v
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #525
Changes made:
main.tshas been moved into modulesupporting-logic.tsunder electron-utils folderelectron-utils/*.jshas been added to.gitignoreElectron) removed frommenu-bar.tsfile for neatnessProposed commit message:
Electron entry script: Move supporting logic into utility functions