Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic profile detection #583

Merged
merged 6 commits into from
Feb 14, 2021

Conversation

ptvrajsk
Copy link
Contributor

@ptvrajsk ptvrajsk commented Feb 7, 2021

This PR fixes #569

Proposed Commit Message:

Removal of Automatic Profile Detection

App initially auto detects profile.json based on executable directory
(only applicable to electron). Hence it is removed as it doesn't apply
to the main web platform.

@ptvrajsk ptvrajsk marked this pull request as ready for review February 7, 2021 13:09
@ptvrajsk ptvrajsk requested a review from anubh-v February 7, 2021 13:09
@ptvrajsk
Copy link
Contributor Author

ptvrajsk commented Feb 7, 2021

@anubh-v Also would it be prudent to do a check on the validity of the profile.json file? Not sure if it is tampered with very much cuz if it is not then we can leave it as is. Currently it JSON.parse() simply checks for whether the file follows the JSON format.

@anubh-v
Copy link
Contributor

anubh-v commented Feb 9, 2021

Also would it be prudent to do a check on the validity of the profile.json file?

Yes, we should. There's an issue for it here

@ptvrajsk
Copy link
Contributor Author

ptvrajsk commented Feb 9, 2021

Yes, we should. There's an issue for it here

Ahh okay sure, that can be a separate PR.

@codecov-io
Copy link

Codecov Report

Merging #583 (cf84db2) into master (c4717c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #583   +/-   ##
=======================================
  Coverage   64.02%   64.02%           
=======================================
  Files          65       65           
  Lines        2071     2071           
  Branches      200      200           
=======================================
  Hits         1326     1326           
  Misses        709      709           
  Partials       36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4717c2...cf84db2. Read the comment docs.

@anubh-v anubh-v changed the title Automatic Profile Detection Removed Remove automatic profile detection Feb 14, 2021
@anubh-v anubh-v merged commit d06b6ee into CATcher-org:master Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "No custom profile found" check
3 participants