-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove automatic profile detection #583
Conversation
@anubh-v Also would it be prudent to do a check on the validity of the profile.json file? Not sure if it is tampered with very much cuz if it is not then we can leave it as is. Currently it |
Yes, we should. There's an issue for it here |
Ahh okay sure, that can be a separate PR. |
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
=======================================
Coverage 64.02% 64.02%
=======================================
Files 65 65
Lines 2071 2071
Branches 200 200
=======================================
Hits 1326 1326
Misses 709 709
Partials 36 36 Continue to review full report at Codecov.
|
This PR fixes #569
Proposed Commit Message: