-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IssueRespondedComponent: Decompose logical expressions into methods #599
IssueRespondedComponent: Decompose logical expressions into methods #599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments wrt to the tests!
Other than that, good job! :D
tests/app/phase-tester-response/issue-responded/issue-responded.component.spec.ts
Show resolved
Hide resolved
tests/app/phase-tester-response/issue-responded/issue-responded.component.spec.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
==========================================
+ Coverage 67.02% 67.20% +0.18%
==========================================
Files 70 71 +1
Lines 2135 2150 +15
Branches 199 199
==========================================
+ Hits 1431 1445 +14
- Misses 663 664 +1
Partials 41 41
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the tests and refactoring! Good work! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Nice Job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comments I've made, LGTM!👍
tests/app/phase-tester-response/issue-responded/issue-responded.component.spec.ts
Outdated
Show resolved
Hide resolved
tests/app/phase-tester-response/issue-responded/issue-responded.component.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but needs some tidying up for the test descriptions.
tests/app/phase-tester-response/issue-responded/issue-responded.component.spec.ts
Outdated
Show resolved
Hide resolved
tests/app/phase-tester-response/issue-responded/issue-responded.component.spec.ts
Outdated
Show resolved
Hide resolved
tests/app/phase-tester-response/issue-responded/issue-responded.component.spec.ts
Outdated
Show resolved
Hide resolved
tests/app/phase-tester-response/issue-responded/issue-responded.component.spec.ts
Outdated
Show resolved
Hide resolved
tests/app/phase-tester-response/issue-responded/issue-responded.component.spec.ts
Outdated
Show resolved
Hide resolved
@dingyuchen can you make the changes? Thanks! |
Addresses a task in #553
Changes:
IssueRespondedComponent
for initialising default filter has been decomposed into separate methodsProposed Commit Message: