Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply next: condition in TestCases that expect an error #607

Closed
ptvrajsk opened this issue Feb 18, 2021 · 0 comments · Fixed by #608
Closed

Supply next: condition in TestCases that expect an error #607

ptvrajsk opened this issue Feb 18, 2021 · 0 comments · Fixed by #608
Assignees
@dingyuchen
Labels
aspect-Testing category.Bug

Comments

@ptvrajsk
Copy link
Contributor

As discussed in #590 (comment), We have some existing test cases that do not supply the next: condition after the subscribe.

So if the test case does not throw an error (which should cause the test case to fail), it doesn't actually fail.

session-model.spec.ts
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dingyuchen dingyuchen

Labels
aspect-Testing category.Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add next handler for Observables' tests dingyuchen/CATcher
2 participants
@dingyuchen @ptvrajsk