-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add next handler for Observables' tests #608
Add next handler for Observables' tests #608
Conversation
This reverts commit 5eea018.
Before I make this PR ready for review @ptvrajsk could you help me take a look at whether I caught all the instances of missing I did a search on all files that matches |
Sure @dingyuchen I'll look through them 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked through my IDE as well and I don't think you missed out on any. Nice job! Just some minor parts to discuss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Summary
This fixes #607, where not supplying the
next
handler lets the test pass automatically when the desired behavior is for an operator to throw an error.Proposed Commit Message