Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Notes: Add section on E2E tests #610

Merged
merged 28 commits into from
Mar 6, 2021
Merged

Conversation

ptvrajsk
Copy link
Contributor

@ptvrajsk ptvrajsk commented Feb 21, 2021

Fixes #606

Proposed Commit Message:

Dev Notes: Add section on E2E tests

Let's add instructions on running the E2E tests
into the Dev Notes, along with information
about the structure and operations of the E2E tests.

@ptvrajsk ptvrajsk marked this pull request as ready for review February 21, 2021 17:08
@ptvrajsk
Copy link
Contributor Author

@anubh-v Not sure if this is too in-depth or is missing any crucial info. Is the structure of it okay as well?

@codecov-io
Copy link

codecov-io commented Feb 21, 2021

Codecov Report

Merging #610 (1ab5e0c) into master (71e3ca9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #610   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          71       71           
  Lines        2150     2150           
  Branches      199      199           
=======================================
  Hits         1445     1445           
+ Misses        664      663    -1     
- Partials       41       42    +1     
Impacted Files Coverage Δ
...rc/app/shared/issue/assignee/assignee.component.ts 91.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e3ca9...1ab5e0c. Read the comment docs.

Copy link
Contributor

@dingyuchen dingyuchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev notes are very helpful 👍
I think I picked up a few spelling errors, and having a newline above headings would make it more readable without preview :)
Other than thanks for the hard work!

docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
@ptvrajsk
Copy link
Contributor Author

Dev notes are very helpful 👍
I think I picked up a few spelling errors, and having a newline above headings would make it more readable without preview :)
Other than thanks for the hard work!

Sure! Haha I think the syntax highlighting lit up the headers for me so I didn't think about adding spaces. I'll put them in for clarity 👍

docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kkangs0226 kkangs0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the section to Dev Notes!:) LGTM other than the minor grammatical mistakes and typo!👍

@ptvrajsk
Copy link
Contributor Author

Thanks for adding the section to Dev Notes!:) LGTM other than the minor grammatical mistakes and typo!👍

Thanks for helping catch the errors! 👍

Copy link
Contributor

@dingyuchen dingyuchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@anubh-v anubh-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. It looks good overall, but let's reorder the sections and use more descriptive section headings.

docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
ptvrajsk and others added 4 commits March 2, 2021 13:04
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Copy link
Contributor

@anubh-v anubh-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments specific to the first two sections.
Thanks alot for writing this up!

docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
ptvrajsk and others added 11 commits March 6, 2021 12:39
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Co-authored-by: Anubhav <35621759+anubh-v@users.noreply.github.com>
Copy link
Contributor

@anubh-v anubh-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one final fix. Thanks for the work

docs/developer-notes.md Outdated Show resolved Hide resolved
docs/developer-notes.md Outdated Show resolved Hide resolved
@anubh-v anubh-v changed the title Add E2E Section to Dev Notes Dev Notes: Add section on E2E tests Mar 6, 2021
@anubh-v anubh-v merged commit 054a5f8 into CATcher-org:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developer notes: Add section on E2E tests
5 participants