-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tester Response: Replace checkbox with radio buttons #618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new change looks great, LGTM!:) Thanks for working on it! Radio buttons are definitely more suited for this purpose.
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
- Coverage 67.72% 67.68% -0.05%
==========================================
Files 75 75
Lines 2259 2259
Branches 207 207
==========================================
- Hits 1530 1529 -1
Misses 686 686
- Partials 43 44 +1
Continue to review full report at Codecov.
|
src/app/shared/view-issue/tester-response/tester-response.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will be good to rename usages of checkbox
to radio
(esp in a few of the existing comments).
src/app/shared/view-issue/tester-response/tester-response.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/view-issue/tester-response/tester-response.component.ts
Outdated
Show resolved
Hide resolved
…cher into TesterResponseRadio
Fixes #415
Old
New
CATcher.3.3.5.-.CATcher-org_bugreporting.-.Brave.2021-03-03.00-44-09.mp4
Proposed Commit Message: