Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tester Response: Replace checkbox with radio buttons #618

Merged
merged 13 commits into from
Mar 25, 2021

Conversation

ptvrajsk
Copy link
Contributor

@ptvrajsk ptvrajsk commented Mar 2, 2021

Fixes #415

Old

image

New

CATcher.3.3.5.-.CATcher-org_bugreporting.-.Brave.2021-03-03.00-44-09.mp4

Proposed Commit Message:

Tester Response: Replace checkbox with radio buttons

In the tester response phase, if the tester agrees with the
team's response, she needs to save the response without modifying
anything else, in order for the agreement to be recorded.

Let's provide a more intuitive method of "agreeing with the
team's response" by using radio buttons that allow the user
to explicitly choose between 'I Disagree' and 'I Agree'.

These radio buttons replace the checkbox control in the
tester response form.

@ptvrajsk ptvrajsk marked this pull request as ready for review March 2, 2021 17:02
@ptvrajsk ptvrajsk requested review from anubh-v and a team March 2, 2021 17:04
Copy link
Contributor

@kkangs0226 kkangs0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new change looks great, LGTM!:) Thanks for working on it! Radio buttons are definitely more suited for this purpose.

@codecov-io
Copy link

codecov-io commented Mar 20, 2021

Codecov Report

Merging #618 (dc880a8) into master (ccd7754) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
- Coverage   67.72%   67.68%   -0.05%     
==========================================
  Files          75       75              
  Lines        2259     2259              
  Branches      207      207              
==========================================
- Hits         1530     1529       -1     
  Misses        686      686              
- Partials       43       44       +1     
Impacted Files Coverage Δ
src/app/shared/issue-tables/issue-sorter.ts 48.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd7754...dc880a8. Read the comment docs.

@ptvrajsk ptvrajsk requested a review from anubh-v March 23, 2021 09:18
Copy link
Contributor

@anubh-v anubh-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will be good to rename usages of checkbox to radio (esp in a few of the existing comments).

@anubh-v anubh-v added this to the V3.3.8 milestone Mar 23, 2021
@anubh-v anubh-v changed the title Tester Response: Added Radio to replace Checkboxes Tester Response: Replace checkboxes with radio buttons Mar 23, 2021
@anubh-v anubh-v changed the title Tester Response: Replace checkboxes with radio buttons Tester Response: Replace checkbox with radio buttons Mar 23, 2021
@anubh-v anubh-v merged commit 1951241 into CATcher-org:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tester response phase: give a clearer way to agree with the team's response
4 participants