Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthService: Throw error if pop-up windows are blocked #647

Merged
merged 4 commits into from
Mar 14, 2021

Conversation

kkangs0226
Copy link
Contributor

Fixes #636

Summary

Pop-up windows are blocked by default on Safari. This causes the authentication window to be blocked, causing users to be stuck on loading screen without any notification.

Changes Made

  • Error message has been added to inform users to enable pop-up windows in their browser
  • Users are brought back to the previous select session page instead of loading screen

Proposed commit message:

AuthService: Throw error message if pop-up windows are blocked

The authentication window is blocked by default in Safari, causing
users to be stuck on loading screen without any notification.

Showing error message to notify users to enable pop-ups and
then directing them back to the start of authentication will
make our application more user-friendly.

Let's
* Show error message when pop-ups are blocked
* Restart authentication process

Pop-up windows are blocked by default on Safari. This causes the
authentication window to be blocked, causing users to be stuck
on loading screen without any notification.

Showing error message to notify users to enable pop-ups and
then directing them back to the start of authentication will
make our application more user-friendly.

Let's
* Show error message when pop-ups are blocked
* Restart authentication process
@kkangs0226 kkangs0226 requested a review from a team March 14, 2021 03:30
@codecov-io
Copy link

codecov-io commented Mar 14, 2021

Codecov Report

Merging #647 (1a3edcc) into master (0be2b05) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #647   +/-   ##
=======================================
  Coverage   67.72%   67.72%           
=======================================
  Files          75       75           
  Lines        2259     2259           
  Branches      207      207           
=======================================
  Hits         1530     1530           
  Misses        686      686           
  Partials       43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be2b05...1a3edcc. Read the comment docs.

src/app/auth/auth.component.ts Outdated Show resolved Hide resolved
src/app/core/services/error-handling.service.ts Outdated Show resolved Hide resolved
@anubh-v anubh-v merged commit 6e01808 into CATcher-org:master Mar 14, 2021
@anubh-v anubh-v changed the title AuthService: Throw error message if pop-up windows are blocked AuthService: Throw error if pop-up windows are blocked Mar 14, 2021
@ptvrajsk ptvrajsk added this to the V3.3.7 milestone Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to load the web version using Safari
4 participants