RepoCreatorService: Create custom operators for permissions request

[seanlowjk]

Summary

This PR fixes #549 by completing the last task of the issue. which abstracts the repo creation permissions request step of sessionSetup() in PhaseService to a single, readable custom operator in RepoCreatorService.

Description

This PR does the following:

1. requestRepoCreationPermissions() takes in two arguments, currentPhase and phaseRepo and checks for the following:
   a. if isSessionAvailable is false and if the currentPhase is Phase.phaseBugReporting, it suggests that there is a need for request of repo creation permissions
   b. Else, no request for permissions is needed.

Suggested Commit Message

RepoCreatorService: Create custom operators for Permissions Request

To improve readability of the session setup code, let's shift the 
request for repo creation permissions code into a custom operator
in RepoCreatorService
  
Let's also add tests for this custom operator.

[damithc]

Suggested Commit Message

RepoCreatorService: Create custom operators for Requesting Repo Creation Permissions

To improve readability of the session setup code,
let's shift the request for repo creation permissions code 
into one custom operators in  RepoCreatorService

Let's also add tests for these custom operator.

Subject seems too long (?) and the body width seems too narrow https://se-education.org/guides/conventions/git.html

[seanlowjk]

Thanks Prof @damithc for the link. I have rectified the subject of the PR and the commit message as followed.

[codecov-io]

Codecov Report

Merging #671 (ac77dda) into master (01ce27e) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   68.38%   68.67%   +0.29%     
==========================================
  Files          75       75              
  Lines        2274     2276       +2     
  Branches      208      207       -1     
==========================================
+ Hits         1555     1563       +8     
+ Misses        675      668       -7     
- Partials       44       45       +1     

Impacted Files	Coverage Δ
src/app/core/services/phase.service.ts	73.01% <ø> (+6.34%)	⬆️
src/app/core/services/repo-creator.service.ts	100.00% <100.00%> (ø)
src/app/shared/issue-tables/issue-sorter.ts	44.00% <0.00%> (-4.00%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ce27e...ac77dda. Read the comment docs.

[ptvrajsk]

Looks mostly good to me 👍 Just some minor queries regarding the test description but great job otherwise 👍

[anubh-v]

Let's rename the SessionFixConfirmationComponent --> RepoCreationConfirmationComponent too.
In my view, "RepoCreation" has a more obvious meaning than "SessionFix".
What do you think?

This renaming can be done separately in another PR.

[seanlowjk]

Yes it would be better to do so!

I think we can do this in a separate PR as well 😄