Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When doing an inspection, the user should work on a copy of the inspection's buildings data. #62

Closed
iamkinetic opened this issue Jun 1, 2018 · 4 comments
Closed

When doing an inspection, the user should work on a copy of the inspection's buildings data. #62

iamkinetic opened this issue Jun 1, 2018 · 4 comments
Assignees
@iamkinetic
Labels
API enhancement New feature or request
Milestone
v1

Comments

@iamkinetic
Copy link
Member

So we need to copy the parent and its children when creating the inspection :

  • BuildingDetail
  • PNAPS, contacts, haz mat
  • particular risks
  • fire protection
  • fire hydrants
  • implantation's plan
  • Etc.

There's no need to change anything on the mobile application for this as all of the controller are already correctly named (like InspectionBuildingPnapController), but we need to change all of these queries so they use the copied data or something.
@iamkinetic iamkinetic added enhancement New feature or request API labels Jun 1, 2018
@iamkinetic iamkinetic modified the milestones: Après ACSIQ, v1 Jun 1, 2018
@iamkinetic
Copy link
Member Author

Il faut décider comment on va faire ça avant de la faire.

@iamkinetic iamkinetic added the help wanted Extra attention is needed label Aug 13, 2018
@iamkinetic
Copy link
Member Author

  • Quand on start l'inspection: on effectue la copie des données.
  • Quand on accepte l'inspection : on fait la copie inverse.

@iamkinetic iamkinetic removed the help wanted Extra attention is needed label Aug 21, 2018
@iamkinetic iamkinetic self-assigned this Aug 21, 2018
iamkinetic added a commit that referenced this issue Aug 21, 2018
@iamkinetic
Feat(#62) Building* refactoring to create a base class for each of th…
40beec0 
…em + new models for building copy.
iamkinetic added a commit that referenced this issue Aug 21, 2018
@iamkinetic
Feat(#62) Modify Inspection's services so they use the copy instead o…
4759312 
…f the original data.
iamkinetic added a commit that referenced this issue Aug 22, 2018
@iamkinetic
Feat(#62) Add mapping for new tables.
3a699a4
iamkinetic added a commit that referenced this issue Aug 22, 2018
@iamkinetic
Feat(#62) Fix inspection building's controllers.
e2a68d7
iamkinetic added a commit that referenced this issue Aug 22, 2018
@iamkinetic
Feat(#62) Refactoring : only one class per file.
eabc0a2
iamkinetic added a commit that referenced this issue Aug 22, 2018
@iamkinetic
Feat(#62) Fix du mapping + remplacement complet de la migration.
e9d1856
@iamkinetic
Copy link
Member Author

#116 fait à même le pull request de cet issue.

iamkinetic added a commit that referenced this issue Aug 22, 2018
@iamkinetic
Feat(#62) Add default inactive filtering on all building and children.
3b6e7c6
iamkinetic added a commit that referenced this issue Aug 22, 2018
@iamkinetic
Feat(#62) Add picture copy.
5b10094
iamkinetic added a commit that referenced this issue Aug 23, 2018
@iamkinetic
Feat(#62) Building* refactoring to create a base class for each of th…
2037f01 
…em + new models for building copy.
iamkinetic added a commit that referenced this issue Aug 23, 2018
@iamkinetic
Feat(#62) Modify Inspection's services so they use the copy instead o…
8723063 
…f the original data.
iamkinetic added a commit that referenced this issue Aug 23, 2018
@iamkinetic
Feat(#62) Add mapping for new tables.
20ea24b
iamkinetic added a commit that referenced this issue Aug 23, 2018
@iamkinetic
Feat(#62) Fix inspection building's controllers.
0d68cc4
iamkinetic added a commit that referenced this issue Aug 23, 2018
@iamkinetic
Feat(#62) Refactoring : only one class per file.
be85899
iamkinetic added a commit that referenced this issue Aug 23, 2018
@iamkinetic
Feat(#62) Fix du mapping + remplacement complet de la migration.
88ffb52
iamkinetic added a commit that referenced this issue Aug 23, 2018
@iamkinetic
Feat(#62) Add default inactive filtering on all building and children.
343a4b5
iamkinetic added a commit that referenced this issue Aug 23, 2018
@iamkinetic
Feat(#62) Add picture copy.
3adcb97
iamkinetic added a commit that referenced this issue Aug 23, 2018
@iamkinetic
Feat(#62) Building* refactoring to create a base class for each of th…
df98a93 
…em + new models for building copy.
iamkinetic added a commit that referenced this issue Aug 23, 2018
@iamkinetic
Feat(#62) Modify Inspection's services so they use the copy instead o…
d069cf4 
…f the original data.
iamkinetic added a commit that referenced this issue Aug 23, 2018
@iamkinetic
Feat(#62) Add mapping for new tables.
0bf1524
iamkinetic added a commit that referenced this issue Aug 28, 2018
@iamkinetic
Fix(#62) Initialiser certaines sous-liste à la création d'objet.
aae0a64
iamkinetic added a commit that referenced this issue Aug 28, 2018
@iamkinetic
Fix(#62) Les images ne s'effacaient pas correctement à cause d'une li…
4464547 
…mitation du type de relation (fake one to many).
iamkinetic added a commit that referenced this issue Aug 28, 2018
@iamkinetic
Fix(#62) Correction code rebase.
e637ff2
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Supprimer la copie lorsqu'on annule une inspection.
0c536de
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Fix(#62) Optimisation de la requête pour éviter le first dans le where.
1310cfa
@iamkinetic
Copy link
Member Author

iamkinetic commented Aug 29, 2018 •
edited
Loading

@philipperobertgh Corriger CAUCA-9-1-1/survip-mobile#150 avant de faire ceci.

This was referenced Aug 29, 2018
Closed
Closed
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Building* refactoring to create a base class for each of th…
af078ef 
…em + new models for building copy.
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Modify Inspection's services so they use the copy instead o…
20d700d 
…f the original data.
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Add mapping for new tables.
429c1c4
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Fix inspection building's controllers.
c749971
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Refactoring : only one class per file.
8989105
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Fix du mapping + remplacement complet de la migration.
ff6776e
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Add default inactive filtering on all building and children.
3461538
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Add picture copy.
cdbde6a
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Refactor code so all changes are made in one save when a vi…
d68aeb0 
…sit is refused by the home owner.
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Fix(#62) Some of the function were still using original data instead …
c36cd59 
…of the copy.
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Add the code to replace the original building with the modi…
fff1df8 
…fied copy.
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Écrasement des données originales par celle de l'inspection…
d5bc2c0 
… acceptée.
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Make the InspectionBuilding* relation "on cascade delete".
16bb88c
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Fix(#62) Change the ToSql extension function so it works again with e…
5050ae9 
…fcore 2.1
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Fix some mapping bug & copy data once the inspection is acc…
f4761bb 
…epted.
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Fix(#62) Initialiser certaines sous-liste à la création d'objet.
f4ad1cc
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Fix(#62) Les images ne s'effacaient pas correctement à cause d'une li…
9dd3676 
…mitation du type de relation (fake one to many).
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Fix(#62) Correction code rebase.
edc9f05
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Feat(#62) Supprimer la copie lorsqu'on annule une inspection.
6fab6f3
iamkinetic added a commit that referenced this issue Aug 29, 2018
@iamkinetic
Fix(#62) Optimisation de la requête pour éviter le first dans le where.
cd2375c
philipperobertgh added a commit that referenced this issue Aug 30, 2018
@philipperobertgh
Merge pull request #122 from CAUCA-9-1-1/#62_Inspection_data_copy
8788644 
#62 inspection data copy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamkinetic iamkinetic

Labels
API enhancement New feature or request
Projects
None yet
Milestone
v1
Development

No branches or pull requests
1 participant
@iamkinetic