Dfki docu fix #25
Open
Dfki docu fix #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rojsc
reviewed
Sep 10, 2018
| @@ -79,7 +79,7 @@ The `extraParameters` provide the addresses of some infrastructure components, f | |||
|
|
|||
| | Parameter name | Optional | Description | | |||
| --- | --- | :--- | | |||
| | `sessionToken` | yes | Session token to be used throughout the workflow | | |||
| | `sessionToken` | no | Session token to be used throughout the workflow | | |||
There was a problem hiding this comment.
I think we do have synchronous services without a session token in the function signature. Is it really non-optional?
There was a problem hiding this comment.
Agreed, this is only mandatory for applications, as those need to it to authenticate with the WFM.
rojsc
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the service type descriptions and fixed a few bugs.