Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show when a keybind is unbound #205

Merged
merged 1 commit into from
Nov 30, 2015
Merged

Show when a keybind is unbound #205

merged 1 commit into from
Nov 30, 2015

Conversation

PabstMirror
Copy link
Contributor

Before it would show all unbound keys as duplicates (red)

@@ -106,6 +106,12 @@ if !(isNull _display) then {
};
};

private _isUnbound = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't work for 1.52

@Killswitch00
Copy link
Contributor

I can not reproduce the problem that this PR supposedly solves. An action for which the assigned key is unbound (deleted) is shown as...well, nothing in the "Assigned keys" column in the configuration dialog.

@PabstMirror
Copy link
Contributor Author

The keys on the bottom are all "unbound", but show up as duplicates in red. I think explicitly showing that they are unbound should be much clearer to users.

2015-11-27_00002

Edit, or we can just not show any text, but I think it's good to get rid of the red duplicate text.

@jonpas
Copy link
Member

jonpas commented Nov 30, 2015

@Killswitch00 If there is only one key unbound in the category it will show up empty (this is fine), but due to empty actually being it's own "key" it will show up as a duplicate bind when having more empty binds.

@Killswitch00
Copy link
Contributor

Thanks for the explanation and screenshot.

@jonpas
Copy link
Member

jonpas commented Nov 30, 2015

👍

@Killswitch00
Copy link
Contributor

As mentioned elsewhere, how about displaying unbound keys as they are displayed in the normal game key assingment dialog, ie with the assigned key field empty? (As PabstMirror said, it would save us the trouble of translating the [UNBOUND] string)

Fix private and mark dikCode -1 or 0 as unbound

Just show blank space for unbound keys

Formatting
@Killswitch00 Killswitch00 added this to the 2.2 milestone Nov 30, 2015
Killswitch00 added a commit that referenced this pull request Nov 30, 2015
@Killswitch00 Killswitch00 merged commit dec0641 into master Nov 30, 2015
@PabstMirror PabstMirror deleted the unboundKeyDisplay branch November 30, 2015 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants