Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable termination of SPARE-* computation #118

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Enable termination of SPARE-* computation #118

merged 1 commit into from
Dec 3, 2021

Conversation

AbdulkadirA
Copy link
Contributor

@AbdulkadirA AbdulkadirA commented Dec 1, 2021 •
edited
Loading

This should properly terminate the computation of the SPARE-* scores.

Fix #117

@AbdulkadirA AbdulkadirA marked this pull request as draft December 1, 2021 14:32
@AbdulkadirA AbdulkadirA marked this pull request as ready for review December 2, 2021 17:05
melhemr
melhemr approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@melhemr melhemr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works after rebasing

@AbdulkadirA AbdulkadirA merged commit 1cc2f75 into CBICA:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melhemr melhemr melhemr approved these changes

@ashishsingh18 ashishsingh18 Awaiting requested review from ashishsingh18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow stopping of SPARE-* computation
3 participants
@AbdulkadirA @ashishsingh18 @melhemr