Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify color palettes for plotting #123

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

melhemr
Copy link
Contributor

@melhemr melhemr commented Dec 3, 2021

Creates a dynamic palette to be used for plotting harmonization boxplots

@melhemr
Copy link
Contributor Author

melhemr commented Dec 3, 2021

@AbdulkadirA I have saved the training model with the color palette dictionary to my comp_space for your use:

/cbica/home/melhemr/comp_space/MUSE_harmonization_model_colors.pkl

@melhemr
Copy link
Contributor Author

melhemr commented Dec 3, 2021

I am considering adding an if statement to check if the color palette dictionary exists in the model. If not, it will create an empty dictionary cSite={}, and the dictionary will be created using the data's SITEs entirely.

@AbdulkadirA
Copy link
Contributor

I am considering adding an if statement to check if the color palette dictionary exists in the model. If not, it will create an empty dictionary cSite={}, and the dictionary will be created using the data's SITEs entirely.

@melhemr Handling of this case is necessary. Thanks for bringing it up.

Copy link
Contributor

@AbdulkadirA AbdulkadirA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melhemr Thanks. It works as expected. I propose to wait until the if statement that checks the presence of a dictionary is implemented.

@melhemr
Copy link
Contributor Author

melhemr commented Dec 3, 2021

@melhemr Thanks. It works as expected. I propose to wait until the if statement that checks the presence of a dictionary is implemented.

Great I will implement it now

@melhemr melhemr marked this pull request as ready for review December 3, 2021 15:32
Copy link
Contributor

@AbdulkadirA AbdulkadirA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@AbdulkadirA AbdulkadirA merged commit 3486911 into CBICA:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants