-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions for creating a conda enviroment with python3.8.8 #181
Conversation
752d588
to
d5e9845
Compare
The only line I wasn't entirely sure how to deal with this line since I am using a mac: Prepare environment for PowerShell (Windows 10 or 11)Assuming conda enviroment with Python version 3.8.8 has been created **& env/Scripts/Activate.ps1**
python -m pip install --upgrade pip
poetry install In these instructions, I've outlined it so the users create a conda enviroment, so I'm not sure where or how the |
@melhemr In my conda env, I usually just do: |
It might be clearer if we create 2 separate sections for installation: one using conda and the other using virtual env. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melhemr Thanks. I made some suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And one more comment ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melhemr Thanks. Please leave the sections on setting up the PIP venv for Windows and Linux as they were and only add a section for conda. You could add the indication of PIP to the exiting section headers, though.
Can you clarify what you mean? I did leave the PIP section alone, and added conda sections as we discussed. Windows for example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melhemr I propose a couple of changes to further simplify.
@AbdulkadirA the changes look good. The only final concern I had is about Ashish's comment above. It seems that using a conda environment with a Windows OS still requires using the command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poetry is generally not required, only to package the toolbox.
PR will add instructions for creating a conda environment to ensure python version is 3.8.8