Added alternative approach to describing Facets more succinctly #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @andyward, |
|
Hi Claudio - I hadn't quite completed it. Will update with a further push and publish. Only change is it does change the output of Short() slightly due to changes to ValueConstraint etc |
|
Sure, no pressure. |
Removes some of the noise from e.g. BaseType in all Short logs WIP: Review Constraint.Short() changes TODO: think how we can internationalise - and maybe make more structured aka ILogger (allowing richer formatting on a client)
ValueConstraint formatting changes Relax checks on FirstCharacter toUpper utility to accept empty string
andyward
force-pushed
the
feature/succinct-descriptions
branch
from
5b0981a
to
a7e583c
Compare
|
Rebased on main. Good to go I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some of the noise from e.g. BaseType in all Short logs WIP: Review Constraint.Short() changes
TODO: think how we can internationalise - and maybe make more structured aka ILogger (allowing richer formatting on a client)