Fixed deserialisation of Required specifications which were appearing as Optional. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't explicitly export minOccurs on xml Export for required specs as default is 1 But we were defaulting MinOccurs to zero and never over-riding if implicit minOccurs. In turn this created the wrong SimpleCardinality when simplifying Fix1: made MinMaxCardinality work in line with xsd defaults (so we import correctly) Fix2: explicitly export the minOccurs for Required to be nice to others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't explicitly export minOccurs on xml Export for Required specs as the xsd minOccurs default is 1
But on load we were defaulting MinOccurs to zero (in MinMaxCardinality) and never over-riding if we had an implicit minOccurs. In turn this created the wrong SimpleCardinality when simplifying
Fix1: made MinMaxCardinality work in line with xsd defaults (so we import correctly) i.e. minOccurs default =1
Fix2: explicitly export the minOccurs for Required (so 3rd parties can be clear of the intent, and to avoid similar bugs elsewhere)
Also allow pretty Xml be enabled/disabled in release modes via a switch