Fix: Ignore whitespace during serialisation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue apparent in xml IDS files where line breaks/tabs etc in the NodeText
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue apparent in xml IDS files where line breaks/tabs etc in a simplevalue NodeText
We now trim simplevalues to more gracefully support input with insignificant whitespace.
Came about from sample IDS with (newline) whitespace in simplevalue elements content.
This is picked up as ContentError by IdsLib schema, but this makes us more graceful. (test case was a moliohouse.ids from cobuilder)
I can't think of any scenario where leading/trailing whitespace on a ExactConstraint will be relevant... @CBenghi ?