Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse Package Version for APRS-IS Login #115

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

CBielstein
Copy link
Owner

Description

Currently, the AprsSharp version sent to the APRS-IS server is hard-coded in to the connection logic. However, the version used for publishing packages is saved in the package properties (Directory.Build.props sets it across all projects/assemblies).

This changes our code to use reflection to get the assembly version of the AprsIsConnection being used to communicate to the server. Thus eliminating one place to remember to change the version on each release. It should now only be required to update the build properties in the code on each version.

Changes

  • Use reflection to reference assembly version for identifying software version to APRS-IS servers

Validation

  • Updated tests
  • Ran AprsSharp CLI and noted the version had updated to the full semver "0.1.0" string
  • Temporarily updated just the AprsIsConnection version to "0.1.1". Verified that APRS-IS saw "AprsSharp 0.1.1" while local --version flag said 0.1.0 still. This verifies it's querying the AprsIsConnection assembly version and not the entrypoint assembly.

@CBielstein CBielstein added the code cleanliness Refactors, static analysis, etc. label Mar 30, 2022
@CBielstein CBielstein self-assigned this Mar 30, 2022
@CBielstein CBielstein merged commit 76dfee8 into main Apr 8, 2022
@CBielstein CBielstein deleted the dyanmic-aprs-is-version branch April 8, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanliness Refactors, static analysis, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant