Rename AprsIsConnection to AprsIsClient #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBielstein
added this to the APRS# Can Receive Packets using APRS Internet Service milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes
AprsIsConnectionproject and class toAprsIsClientto match more closely with .NET naming conventions (TcpClient,HttpClient, etc.). It's also a slightly more descriptive name as this is coded exclusively as a client implementation, not a server, so it's arguably not a generic connection between APRS-IS nodes.This also brings the code in line with the name of the nuget package AprsSharp.AprsIsClient.
Changes
AprsIsConnectiontoAprsIsClient(both object and project)AprsIsConnectionUniteTeststoAprsIsClientUnitTestsand related file renamesValidation