Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Typo in Position Regex #132

Merged
merged 2 commits into from
May 15, 2022
Merged

Correct Typo in Position Regex #132

merged 2 commits into from
May 15, 2022

Conversation

CBielstein
Copy link
Owner

Description

The regular expression for a position with symbols had a typo specifying latitude in north and west instead of north and south. This PR corrects that typo and adds a test to validate the change.

Changes

  • Fix typo in regex
  • Add test

Validation

  • Add test in south and east lat/long to ensure all directions are parsing correctly
  • All tests passing

@CBielstein CBielstein added the bug Something isn't working label May 15, 2022
@CBielstein CBielstein self-assigned this May 15, 2022
@CBielstein CBielstein requested a review from eddywine as a code owner May 15, 2022 21:10
@CBielstein CBielstein merged commit beaf481 into main May 15, 2022
@CBielstein CBielstein deleted the position-regex-fix branch May 15, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant